Skip to content

Remove duplicated version_compare ReplaceFuncCallArgumentDefaultValue rule#4473

Merged
samsonasik merged 1 commit intorectorphp:mainfrom
alexander-schranz:patch-1
Jul 10, 2023
Merged

Remove duplicated version_compare ReplaceFuncCallArgumentDefaultValue rule#4473
samsonasik merged 1 commit intorectorphp:mainfrom
alexander-schranz:patch-1

Conversation

@alexander-schranz
Copy link
Copy Markdown
Contributor

@alexander-schranz alexander-schranz commented Jul 10, 2023 •
edited
Loading 

+            new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'gte', 'ge'),
+            new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'lte', 'le'),
             new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, '', '!='),
             new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, '!', '!='),
             new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'g', 'gt'),
             new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'l', 'lt'),
-            new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'gte', 'ge'),
-            new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'lte', 'le'),
             new ReplaceFuncCallArgumentDefaultValue('version_compare', 2, 'n', 'ne'),

already defined in Line 1 and 2.

@samsonasik samsonasik merged commit aac0f2a into rectorphp:main Jul 10, 2023
@samsonasik
Copy link
Copy Markdown
Member

samsonasik commented Jul 10, 2023

Thank you @alexander-schranz

@alexander-schranz alexander-schranz deleted the patch-1 branch July 10, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexander-schranz @samsonasik